Skip to content

Code Qaulity: Improved compatibility mode classes #14473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jan 16, 2024

Summary

  • Refactored compat-related classes

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Go to Compatibility page
    2. Confirm everything behaves as expected

Copy link
Contributor

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing

@0x5bfa 0x5bfa requested a review from Jay-o-Way January 21, 2024 16:00
Copy link
Contributor

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many ways to improve XAML on a large [app-scope] scale. Would need some investment, though.

@0x5bfa 0x5bfa requested a review from Jay-o-Way February 9, 2024 00:48
@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels Feb 18, 2024
@yaira2 yaira2 self-assigned this Feb 18, 2024
@0x5bfa
Copy link
Member Author

0x5bfa commented Feb 18, 2024

Why is changes requested Changes are needed for this pull request added?

@yaira2
Copy link
Member

yaira2 commented Feb 18, 2024

We'd like the design changes to be separated from the code improvements, this way we can merge the code improvements while we discuss the design changes.

@0x5bfa 0x5bfa closed this Feb 25, 2024
@0x5bfa 0x5bfa deleted the 5bfa/Improve-CompatPropsPage branch February 25, 2024 23:26
@0x5bfa 0x5bfa restored the 5bfa/Improve-CompatPropsPage branch February 26, 2024 00:08
@0x5bfa 0x5bfa reopened this Feb 26, 2024
@0x5bfa 0x5bfa marked this pull request as draft February 26, 2024 00:15
@0x5bfa 0x5bfa removed the request for review from Jay-o-Way February 26, 2024 01:12
@0x5bfa 0x5bfa changed the title Feature: Improved compatibility page of properties window Feature: Improved compatibility mode classes Feb 26, 2024
@0x5bfa 0x5bfa marked this pull request as ready for review February 26, 2024 01:13
@0x5bfa 0x5bfa changed the title Feature: Improved compatibility mode classes Code Qaulity: Improved compatibility mode classes Feb 26, 2024
@0x5bfa
Copy link
Member Author

0x5bfa commented Feb 26, 2024

Ready for review.

@yaira2 yaira2 added needs - code review and removed changes requested Changes are needed for this pull request labels Feb 27, 2024
@yaira2 yaira2 force-pushed the 5bfa/Improve-CompatPropsPage branch 5 times, most recently from 65ebb15 to 58e21d9 Compare February 27, 2024 17:45
@yaira2 yaira2 force-pushed the 5bfa/Improve-CompatPropsPage branch from 58e21d9 to f3fda44 Compare February 27, 2024 17:46
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit a9557ed into files-community:main Feb 28, 2024
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 28, 2024
@0x5bfa 0x5bfa deleted the 5bfa/Improve-CompatPropsPage branch February 28, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants