Skip to content

Fix: Fixed an issue with dropping multiple items onto executable files #14067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

antonioseet
Copy link
Contributor

…also checks to see if python is installed on system before allowing the drop like in File Explorer.
removed redundant code

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Create 4 types of files: test.py, test.bat, test.cmd, test.exe. Each created to test incoming arguments list.
      image
      image
      image
      image

Tested dragging and dropping multiple files to each of them to verify changes:
image

Also validated that when python is not installed, the user cannot drop files onto the python file.

…also checks to see if python is installed on system before allowing the drop like in File Explorer.
@antonioseet antonioseet changed the title Able to drop multiple files into executable files and python files. Fix: Fixed an issue with drag and dropping multiple items onto executable files Nov 25, 2023
@antonioseet antonioseet changed the title Fix: Fixed an issue with drag and dropping multiple items onto executable files Fix: Fixed an issue with drag and dropping multiple items onto executable files (including python files) Nov 25, 2023
@yaira2 yaira2 changed the title Fix: Fixed an issue with drag and dropping multiple items onto executable files (including python files) Fix: Fixed an issue with dropping multiple items onto executable files Nov 25, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 26, 2023
@yaira2 yaira2 merged commit 2e43a1a into files-community:main Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Drag-and-Drop Multiple Files Opens Multiple Instances Instead of Passing as Arguments for .py and .bat Files
2 participants