Skip to content

Fix: Fixed IO Error in RunCompatibilityTroubleshooterAsync #13920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Fix: Fixed IO Error in RunCompatibilityTroubleshooterAsync #13920

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8d91b41
Fix: Fixed IO Error in RunCompatibilityTroubleshooterAsync
yaira2 Nov 16, 2023
d76f226
Update LaunchHelper.cs
yaira2 Nov 16, 2023
26a68a0
Update LaunchHelper.cs
yaira2 Nov 17, 2023
e9f682b
Update LaunchHelper.cs
yaira2 Nov 17, 2023
0500e8e
Merge branch 'main' into ya/FixedIOError
yaira2 Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/Files.App/Utils/Shell/LaunchHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,20 @@ public static Task<bool> LaunchAppAsync(string application, string arguments, st
public static Task<bool> RunCompatibilityTroubleshooterAsync(string filePath)
{
var compatibilityTroubleshooterAnswerFile = Path.Combine(Path.GetTempPath(), "CompatibilityTroubleshooterAnswerFile.xml");
File.WriteAllText(compatibilityTroubleshooterAnswerFile, string.Format("<?xml version=\"1.0\" encoding=\"UTF-8\"?><Answers Version=\"1.0\"><Interaction ID=\"IT_LaunchMethod\"><Value>CompatTab</Value></Interaction><Interaction ID=\"IT_BrowseForFile\"><Value>{0}</Value></Interaction></Answers>", filePath));

try
{
File.WriteAllText(compatibilityTroubleshooterAnswerFile, string.Format("<?xml version=\"1.0\" encoding=\"UTF-8\"?><Answers Version=\"1.0\"><Interaction ID=\"IT_LaunchMethod\"><Value>CompatTab</Value></Interaction><Interaction ID=\"IT_BrowseForFile\"><Value>{0}</Value></Interaction></Answers>", filePath));
}
catch (IOException)
{
// Try with a different file name
SafetyExtensions.IgnoreExceptions(() =>
{
compatibilityTroubleshooterAnswerFile = Path.Combine(Path.GetTempPath(), "CompatibilityTroubleshooterAnswerFile1.xml");
File.WriteAllText(compatibilityTroubleshooterAnswerFile, string.Format("<?xml version=\"1.0\" encoding=\"UTF-8\"?><Answers Version=\"1.0\"><Interaction ID=\"IT_LaunchMethod\"><Value>CompatTab</Value></Interaction><Interaction ID=\"IT_BrowseForFile\"><Value>{0}</Value></Interaction></Answers>", filePath));
});
}

return HandleApplicationLaunch("MSDT.exe", $"/id PCWDiagnostic /af \"{compatibilityTroubleshooterAnswerFile}\"", "");
}
Expand Down