Skip to content

Fix: Always set content dialog root #13859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fix: Always set content dialog root #13859

merged 1 commit into from
Nov 15, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 13, 2023

Resolved / Related Issues

  • Fix potential crashes that could occur if the root isn't set

@yaira2 yaira2 requested a review from d2dyno1 November 13, 2023 23:10
@yaira2
Fix: Always set content dialog root
5081fbd 
Revert "Fix: Always set content dialog root"

This reverts commit 119068c.

Update DecompressHelper.cs

Update CompressIntoArchiveAction.cs

Update UpdateService.cs

Root
@yaira2 yaira2 force-pushed the ya/SetContentDialogRoot branch from 6bb8c9b to 5081fbd Compare November 13, 2023 23:21
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 15, 2023
@yaira2 yaira2 merged commit 6800b1c into main Nov 15, 2023
@yaira2 yaira2 deleted the ya/SetContentDialogRoot branch November 15, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d2dyno1 d2dyno1 d2dyno1 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaira2 @d2dyno1