Skip to content

Fix: Improved the speed graph #13629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 10, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Nov 1, 2023

Summary

Fixed some issues reported by other contributors.

Task Checklist

  • Fixed an issue where the graph gets elevated when the graph reaches the maximum Y point.
  • Fixed an issue where it will incorrectly report a successful operation instead of marking it as canceled when selected one or more folders only and initiate compression, then cancel it,
  • Fixed an issue where it will erroneously report a failure instead of marking it as canceled when started decompression, then cancel it, it will indicate success instead of marking it as canceled when selected one or more folders with one or more files and start compression, then cancel it,
  • Clean up
  • Apply requested changes

Known Issues

There still are some room of string resource improvements but not the scope of this PR.

PR Checklist

Steps To Validate Changes

  1. Launch the app
  2. Go to folder content view
  3. Copy files a lot
  4. Open the Status Center
  5. You now recognize the graph no longer moves up when the highest point updated.
  6. You now recognize the cancelation state for compression/decompression is shown properly.

Screenshots

N/A

Footnotes

  1. If the request hasn't been agreed by the team, this work might be rejected. Make sure that you get approval from the team before opening any PR related the request.

  2. If you removed any en-US string resources, make sure that there are no references of those resources. When you add a new en-US string resources, do not make any changes on other languages' resources; Crowdin will do that, instead.

@0x5bfa 0x5bfa changed the title Fix: Fixed issues where the speed graph would be unreliable Fix: Improved the speed graph Nov 4, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 10, 2023
@yaira2 yaira2 merged commit 1d7cee0 into files-community:main Nov 10, 2023
@0x5bfa 0x5bfa deleted the 5bfa/Improve-SpeedGraph branch November 18, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants