Skip to content

Feature: Added ctrl + alt + c shortcut to copy path with quotes #13398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 28, 2023

Conversation

niklasb22
Copy link
Contributor

@niklasb22 niklasb22 commented Sep 19, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes: Feature: Ctrl + shift to copy as path with quotes #12545

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Select item and use ctrl + alt + c shortcut
    2. Confirm the path is copied to the clipboard with quotes

Screenshots (optional)
Add screenshots here.

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of codebasel except one thing.

Are there any other steps that were used to validate these changes?

Please wwrite down.

@yaira2 yaira2 changed the title Feature: Added support to put quotes arround a path, by using Ctrl+Shift Feature: Added alt modifier key to copy path with quotes Sep 21, 2023
@yaira2 yaira2 changed the title Feature: Added alt modifier key to copy path with quotes Feature: Added modifier key to copy path with quotes Sep 21, 2023
@yaira2 yaira2 force-pushed the main branch 5 times, most recently from a827a37 to 20e04d0 Compare November 2, 2023 18:32
@yaira2 yaira2 force-pushed the main branch 3 times, most recently from cecddda to 7f8c927 Compare November 17, 2023 16:57
@yaira2
Copy link
Member

yaira2 commented Nov 26, 2023

@niklasb22 we're ready to move forward with this feature. The changes look good but one thing I would suggest doing differently, instead of adding a modifier key, it might be best to create a separate action with a different shortcut.

@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels Nov 26, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Nov 28, 2023
@yaira2 yaira2 changed the title Feature: Added modifier key to copy path with quotes Feature: Added ctrl + alt + c shortcut to copy path with quotes Nov 28, 2023
@yaira2 yaira2 merged commit 2f607d3 into files-community:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Ctrl + shift to copy as path with quotes
3 participants