-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Feature: Added ctrl + alt + c
shortcut to copy path with quotes
#13398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ift while clicking copy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in terms of codebasel except one thing.
Are there any other steps that were used to validate these changes?
Please wwrite down.
alt
modifier key to copy path with quotes
alt
modifier key to copy path with quotesa827a37
to
20e04d0
Compare
cecddda
to
7f8c927
Compare
@niklasb22 we're ready to move forward with this feature. The changes look good but one thing I would suggest doing differently, instead of adding a modifier key, it might be best to create a separate action with a different shortcut. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ctrl + alt + c
shortcut to copy path with quotes
Resolved / Related Issues
Closes: Feature: Ctrl + shift to copy as path with quotes #12545
Validation
How did you test these changes?
ctrl + alt + c
shortcutScreenshots (optional)
Add screenshots here.