Skip to content

Codebase Quality: Closes issue#13350 Implement AppLifecycleHelper class to improve readability of App.xaml.cs #13392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jvestell
Copy link
Contributor

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

@jvestell
Copy link
Contributor Author

jvestell commented Sep 18, 2023

@0x5bfa Service registration order matters. Can I get your feedback here? Ready to build.
@yaira2

@jvestell
Copy link
Contributor Author

@d2dyno1 Thanks for your comment on the issue itself. Could you look at this PR and be more specific about your comment? Thanks


namespace Files.App.Helpers.ServiceRegistration
{
public class AppLifecycleHelper
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class could be made static

@yaira2 yaira2 force-pushed the main branch 5 times, most recently from a827a37 to 20e04d0 Compare November 2, 2023 18:32
@yaira2 yaira2 force-pushed the main branch 3 times, most recently from cecddda to 7f8c927 Compare November 17, 2023 16:57
@yaira2 yaira2 closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Quality: Break down service registration in App.xaml.cs into granular methods
3 participants