Skip to content

Feature: Redesigned the app icon #13247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 25, 2023
Merged

Feature: Redesigned the app icon #13247

merged 10 commits into from
Aug 25, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Aug 24, 2023 •
edited
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Built the app and confirmed the dev icons were working properly
    2. Renamed the preview folder to dev and confirmed the preview icons were working properly
    3. Renamed the release folder to dev and confirmed the release icons were working properly

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 requested a review from 0x5bfa August 24, 2023 22:20
0x5bfa
0x5bfa approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic!!!

@0x5bfa

This comment was marked as outdated.

Sign in to view
@yaira2

This comment was marked as outdated.

Sign in to view
@yaira2 yaira2 merged commit 94add2e into main Aug 25, 2023
@yaira2 yaira2 deleted the ya/Icons branch August 25, 2023 14:05
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Aug 25, 2023
@mon-jai
Copy link

mon-jai commented Oct 4, 2023

@yaira2 Maybe we should also include vector version of the icon, and put that to README instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x5bfa 0x5bfa 0x5bfa approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaira2 @0x5bfa @mon-jai