Skip to content

Feature: Updated icons in the Tag column in the Details layout #13060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jul 24, 2023

Resolved / Related Issues

  • Updated icons in the Tag column in the Details layout
  • Added background color when hovering over a tag
  • Removed the border color

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Enable the Details layout
    2. Apply a tag to a file
    3. Hover over the tag in the tag column
    4. Confirm it matches the expect design
    5. Click the icon to remove the tag and confirm it works as expected

Screenshots (optional)
image

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 24, 2023
@yaira2 yaira2 merged commit d1bdd2e into main Jul 24, 2023
@yaira2 yaira2 deleted the ya/TagColumn branch August 13, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant