Skip to content

Fix: Fixed issue where "Open in new window" followed the startup settings #12853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: "Open in new window" follows the startup settings #12812

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. If you perform "Open in new window", the new window will contain a tab of selected item only.
    2. If you launch the app from command line with a path to open, it will still follow the startup settings.

@yaira2
Copy link
Member

yaira2 commented Jul 5, 2023

An alternative approach could be to check for an existing instance, besides fixing this issue, it'll help if the user opens a second instance from the Start Menu or Taskbar.

@hishitetsu
Copy link
Member Author

An alternative approach could be to check for an existing instance, besides fixing this issue, it'll help if the user opens a second instance from the Start Menu or Taskbar.

Even now, when I open the second instance when the startup setting is "Continue where you left off", only the home page is displayed in the new window. Also, if I try to launch the app by specifying a folder while the app is already running, a new tab will be added to the existing window.
So I think it is fine as it is.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 5, 2023
@yaira2 yaira2 merged commit 1de78a1 into files-community:main Jul 5, 2023
@hishitetsu hishitetsu deleted the FixOpenInNewWindow branch July 6, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: "Open in new window" follows the startup settings
2 participants