Skip to content

Code Quality: Rename Files.OpenDialog #12845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 9, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jul 4, 2023

Code Quality: Rename Files.OpenDialog

Motivation & Context

  • Improved readability
  • Improved maintainability
  • Simplified project files

Warning
Please do not review code lines that I did not changed. I cannot make more diff. If there're more codes that are preferred to change, I will do that and mark that PR as the final one for that stage.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related Feature: Improving Performance, optimizations, reliability and codebase  #4180
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots

None

@0x5bfa 0x5bfa marked this pull request as draft July 4, 2023 06:55
@0x5bfa 0x5bfa closed this Jul 4, 2023
@0x5bfa 0x5bfa deleted the 5bfa/Rename-OpenDialog branch July 4, 2023 15:11
@0x5bfa 0x5bfa restored the 5bfa/Rename-OpenDialog branch July 5, 2023 03:13
@0x5bfa 0x5bfa reopened this Jul 5, 2023
@yaira2 yaira2 requested a review from gave92 July 5, 2023 03:55
@0x5bfa 0x5bfa marked this pull request as ready for review July 5, 2023 04:46
@0x5bfa
Copy link
Member Author

0x5bfa commented Jul 5, 2023

I still have to-do

  • Check if the output files will be put into the appropriate place.
  • Check other concerns about renaming C++ project path and name by building projects.

@gave92
Copy link
Member

gave92 commented Jul 5, 2023

Hi I've pushed some suggested changes & fixes to 0x5bfa#4

@0x5bfa
Copy link
Member Author

0x5bfa commented Jul 6, 2023

Just merged, thank you! @gave92 Can you re-review?

@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review ready to merge Pull requests that are approved and ready to merge labels Jul 8, 2023
@gave92 gave92 self-requested a review July 8, 2023 16:04
@gave92
Copy link
Member

gave92 commented Jul 8, 2023

Uops setting Files as default is broken here. See 0x5bfa#5.

@gave92 gave92 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 9, 2023
@yaira2 yaira2 merged commit a8942f0 into files-community:main Jul 9, 2023
@0x5bfa 0x5bfa deleted the 5bfa/Rename-OpenDialog branch September 16, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants