Skip to content

Fix: Fixed issue where long tag names weren't clipped #12802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Fix: Fixed issue where long tag names weren't clipped #12802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Files.App/Views/Settings/TagsPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@
Glyph="" />
<TextBlock
x:Name="TagName"
MaxWidth="200"
Padding="8,0,0,0"
VerticalAlignment="Center"
FontSize="12"
Expand Down Expand Up @@ -341,7 +342,7 @@
<Button
x:Name="SaveChangesButton"
Click="CommitRenameTag_Click"
Content="{helpers:ResourceString Name=SaveChanges}"
Content="{helpers:ResourceString Name=Save}"
Comment on lines -344 to +345
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the string resource SaveChanges also be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, you're right

IsEnabled="{x:Bind CanCommit, Mode=OneWay}"
Style="{StaticResource AccentButtonStyle}" />
</StackPanel>
Expand Down