Skip to content

Feature: Support changing behavior of buttons with modifier keys #12728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 28, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Holding down Shift and pressing the delete button on the toolbar or flyout will result in permanent deletion.
    2. Holding down Shift and pressing the paste button on the toolbar will paste items into selected folder. If no items are selected, it will act as normal pasting.

Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback about the code. I cannot test it though. Some interesting feature that might be very powerful on the long run.

To be honest fully, there is a little something feeling wrong to me but I cannot pinpoint what... I'll be sure to come back to elaborate when I have IDE to review it properly.

Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test the code, yet with the suggested refactoring done, I trust the concept way more!

LGTM, I'll need someone else to test the code.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jun 28, 2023
@yaira2 yaira2 merged commit fd002b5 into files-community:main Jun 28, 2023
@hishitetsu hishitetsu deleted the ChangeBehavior branch June 28, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Change the behavior of toolbar and flyout buttons with modifier keys
3 participants