Skip to content

Fix: Fixed issue where folder sizes weren't shown in Recycle Bin #12630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

tanchekwei
Copy link
Contributor

@tanchekwei tanchekwei commented Jun 16, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Folder size isn't shown in the recycle bin #11043

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Comment:

This pull request fixed the folder size appears blank in the recycle bin.

  1. Tested recycle bin shows folders with their sizes
  2. Tested folders with their sizes are correctly displayed when searching within the recycle bin.
  3. Tested status bar at the bottom able to displays the total size of the recycle bin, whether all files and folders are selected or not.

Screenshots (optional)

Before

image

After

image

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix: Fixed Folder Size Showing Blank in Recycle Bin Fix: Fixed issue where folder sizes weren't shown in Recycle Bin Jun 16, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jun 16, 2023
@yaira2 yaira2 merged commit 19dc9ad into files-community:main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Folder size isn't shown in the recycle bin
2 participants