[Help Wanted] dev/lubl/file-enum #12601
Conversation
| /// <summary> | ||
| /// Represents a watcher for the trash bin | ||
| /// </summary> | ||
| public interface ITrashWatcher : IWatcher |
There was a problem hiding this comment.
How about we use or inherit from IFolderWatcher?
|
|
||
| namespace Files.Sdk.Storage.MutableStorage | ||
| { | ||
| /// <summary> | ||
| /// A disposable object which can notify of changes to the folder. | ||
| /// </summary> | ||
| public interface IFolderWatcher : INotifyCollectionChanged, IDisposable, IAsyncDisposable | ||
| public interface IFolderWatcher : INotifyCollectionChanged, IDisposable, IAsyncDisposable, IWatcher |
There was a problem hiding this comment.
Change tracking events are already supplemented by INotifyCollectionChanged
| /// <summary> | ||
| /// Starts the watcher | ||
| /// </summary> | ||
| void Start(); |
There was a problem hiding this comment.
Retrieving IFolderWatcher assumes that it's already tracking for changes.
| /// <summary> | ||
| /// Stops the watcher | ||
| /// </summary> | ||
| void Stop(); |
There was a problem hiding this comment.
Stopping the IFolderWatcher is done through either IDisposable.Dispose() or IAsyncDisposable.DisposeAsync()
| @@ -197,5 +199,43 @@ public async Task<IFolder> CreateFolderAsync(string desiredName, CreationCollisi | |||
|
|
|||
| return new FtpStorageFolder(newPath, desiredName); | |||
| } | |||
|
|
|||
| public async IAsyncEnumerable<IStorable> SearchAsync(string userQuery, SearchDepth depth = SearchDepth.Shallow) | |||
There was a problem hiding this comment.
Could this be an extension method?
| /// </summary> | ||
| /// <param name="userQuery">A string containing specific terms which influence search results</param> | ||
| /// <returns>The search results produced by the query</returns> | ||
| IAsyncEnumerable<IStorable> SearchAsync(string userQuery, SearchDepth depth = SearchDepth.Shallow); |
There was a problem hiding this comment.
If it's a necessity, add another interface that'd provide the search function (e.g.: ISearchableFolder)
|
Hi! Why was this pull request closed? 🤔 |
Resolved / Related Issues
Closes #issue...
Validation
How did you test these changes?
Screenshots (optional)
Add screenshots here.