Skip to content

Feature: Automatically hide the preview pane when the window is too small #12499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented May 31, 2023

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open the preview pane
    2. Make window as narrow as possible
    3. Start reducing the window height until there is only enough space for around three items in the details layout
    4. Confirm that the preview pane automatically hides
    5. Make the window wider until the preview pane is visible on the right
    6. Reduce the window height until there is just enough space to view the item details in the preview pane
    7. Confirm that the preview pane hides if you continue to reduce the window height

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Feature: Increased minimum window height at which the preview gets hi… Feature: Automatically hide the preview pane when the window is too small May 31, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 31, 2023
@yaira2 yaira2 merged commit 8b9626c into main May 31, 2023
@yaira2 yaira2 deleted the ya/PreviewHide branch May 31, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Increase the minimum window height at which the preview gets hidden
1 participant