Skip to content

Feature: Show a tooltip when a text in the details view is trimmed #12488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2023
Merged

Feature: Show a tooltip when a text in the details view is trimmed #12488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5814383
Show tooltip for trimmed text
hishitetsu May 30, 2023
a5a7887
Update src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml.cs
hishitetsu May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,7 @@
<TextBlock
x:Name="ItemName"
VerticalAlignment="Center"
IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged"
Opacity="{x:Bind Opacity, Mode=OneWay}"
Text="{x:Bind Name, Mode=OneWay}"
TextTrimming="CharacterEllipsis" />
Expand Down Expand Up @@ -720,6 +721,7 @@
HorizontalAlignment="Stretch"
VerticalAlignment="Center"
x:Load="{x:Bind IsRecycleBinItem}"
IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged"
Style="{StaticResource ColumnContentTextBlock}"
Text="{x:Bind AsRecycleBinItem.ItemOriginalPath, Mode=OneWay}"
Visibility="{Binding ColumnsViewModel.OriginalPathColumn.Visibility, ElementName=PageRoot, Mode=OneWay}" />
Expand All @@ -731,6 +733,7 @@
HorizontalAlignment="Stretch"
VerticalAlignment="Center"
x:Load="{x:Bind IsRecycleBinItem}"
IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged"
Style="{StaticResource ColumnContentTextBlock}"
Text="{x:Bind AsRecycleBinItem.ItemDateDeleted, Mode=OneWay}"
Visibility="{Binding ColumnsViewModel.DateDeletedColumn.Visibility, ElementName=PageRoot, Mode=OneWay}" />
Expand All @@ -741,6 +744,7 @@
Padding="12,0,0,0"
HorizontalAlignment="Stretch"
VerticalAlignment="Center"
IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged"
Style="{StaticResource ColumnContentTextBlock}"
Text="{x:Bind ItemDateModified, Mode=OneWay}"
Visibility="{Binding ColumnsViewModel.DateModifiedColumn.Visibility, ElementName=PageRoot, Mode=OneWay}" />
Expand All @@ -751,6 +755,7 @@
Padding="12,0,0,0"
HorizontalAlignment="Stretch"
VerticalAlignment="Center"
IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged"
Style="{StaticResource ColumnContentTextBlock}"
Text="{x:Bind ItemDateCreated, Mode=OneWay}"
Visibility="{Binding ColumnsViewModel.DateCreatedColumn.Visibility, ElementName=PageRoot, Mode=OneWay}" />
Expand All @@ -761,6 +766,7 @@
Padding="12,0,0,0"
HorizontalAlignment="Stretch"
VerticalAlignment="Center"
IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged"
Style="{StaticResource ColumnContentTextBlock}"
Text="{x:Bind ItemType, Mode=OneWay}"
Visibility="{Binding ColumnsViewModel.ItemTypeColumn.Visibility, ElementName=PageRoot, Mode=OneWay}" />
Expand All @@ -771,6 +777,7 @@
Padding="12,0,0,0"
HorizontalAlignment="Stretch"
VerticalAlignment="Center"
IsTextTrimmedChanged="TextBlock_IsTextTrimmedChanged"
Style="{StaticResource ColumnContentTextBlock}"
Text="{x:Bind FileSize, Mode=OneWay}"
Visibility="{Binding ColumnsViewModel.SizeColumn.Visibility, ElementName=PageRoot, Mode=OneWay}" />
Expand Down
6 changes: 6 additions & 0 deletions src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,5 +804,11 @@ private void UpdateCheckboxVisibility(object sender, bool isPointerOver)
VisualStateManager.GoToState(userControl, "HideCheckbox", true);
}
}

// Workaround for https://github.com/microsoft/microsoft-ui-xaml/issues/170
private void TextBlock_IsTextTrimmedChanged(TextBlock sender, IsTextTrimmedChangedEventArgs e)
{
ToolTipService.SetToolTip(sender, sender.IsTextTrimmed ? sender.Text : null);
}
}
}