Skip to content

Fix: Fixed System.ArgumentException caused by adding the same key #12302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2023
Merged

Fix: Fixed System.ArgumentException caused by adding the same key #12302

merged 2 commits into from
May 11, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@hishitetsu hishitetsu marked this pull request as draft May 7, 2023 08:58
@hishitetsu hishitetsu force-pushed the FixArgumentException branch from ebec006 to 5d2f211 Compare May 7, 2023 09:27
@hishitetsu hishitetsu force-pushed the FixArgumentException branch from 5d2f211 to 92ca972 Compare May 7, 2023 09:28
@hishitetsu hishitetsu marked this pull request as ready for review May 7, 2023 09:29
@yaira2 yaira2 requested a review from hez2010 May 9, 2023 03:26
@hez2010
Copy link
Member

hez2010 commented May 9, 2023 •
edited
Loading

Thank you for your contribution.
I'm a bit confused about what this PR is trying to resolve, can you elaborate (e.g. the steps to reproduce this issue) so we can continue to review the work you have done?

@hishitetsu
Copy link
Member Author

hishitetsu commented May 9, 2023 •
edited
Loading

@hez2010
This is a fix for the following crash reported by App Center.
image
I don't know how to reproduce it, but it is one of the frequently reported crashes.

yaira2
yaira2 approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 11, 2023
@yaira2 yaira2 changed the title Fix: Fixed crash caused by adding the same key Fix: Fixed System.ArgumentException caused by adding the same key May 11, 2023
@yaira2 yaira2 merged commit 386b0dd into files-community:main May 11, 2023
@hishitetsu hishitetsu deleted the FixArgumentException branch May 12, 2023 00:21
hishitetsu added a commit to hishitetsu/Files that referenced this pull request May 12, 2023
@hishitetsu
Fix: Fixed System.ArgumentException caused by adding the same key (fi…
1042d49 
…les-community#12302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@hez2010 hez2010 Awaiting requested review from hez2010

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hishitetsu @hez2010 @yaira2