Skip to content

Feature: Rename the "Path:" text to "Location" feature. #12248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

munnanadaf
Copy link

@munnanadaf munnanadaf commented May 1, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title #11950 issue Feature: Rename the "Path:" text to "Location" feature. Feature: Rename the "Path:" text to "Location" feature. May 1, 2023
@0x5bfa
Copy link
Member

0x5bfa commented May 1, 2023

This is already resolving by #12243.

@yaira2
Copy link
Member

yaira2 commented May 1, 2023

@munnanadaf thank you for taking the time to open this PR, it looks like someone beat you to this by a couple of hours and it was implemented in #12243. If you're interested, let me know and I can suggest a different issue for you to work on.

@yaira2 yaira2 closed this May 1, 2023
@munnanadaf
Copy link
Author

munnanadaf commented May 1, 2023 via email

@yaira2
Copy link
Member

yaira2 commented May 1, 2023

@munnanadaf how about #11945? If you decide to work on this, please note that it's enough to update the en-us resw file. The other files will automatically update in Crowdin.

@munnanadaf
Copy link
Author

munnanadaf commented May 1, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants