Skip to content

Code Quality: Introduce a new data storage namespace #12233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 30, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Apr 29, 2023

Code Quality: Introduce a new data storage namespace

Motivation and Context

Since there's no namespace for parameters, event args, factories, models, items, and so on, the developer tries to solve this by adding multiple classes in one file. To fix this, I introduced a new data storage namespace so that the codebase reliability will not be reduced.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots

New:
image

Problem:
image

@0x5bfa 0x5bfa changed the title Code Quality: Introduce a new data storing namespace Code Quality: Introduce a new data storage namespace Apr 29, 2023
@0x5bfa
Copy link
Member Author

0x5bfa commented Apr 29, 2023

Ready for review.

Copy link
Member

@d2dyno1 d2dyno1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a positive change. Thank you!

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 30, 2023
@yaira2
Copy link
Member

yaira2 commented Apr 30, 2023

@0x5bfa can you fix the merge conflict?

@0x5bfa
Copy link
Member Author

0x5bfa commented Apr 30, 2023

@yaira2 Fixed

@yaira2 yaira2 merged commit d8d10c2 into files-community:main Apr 30, 2023
@0x5bfa 0x5bfa deleted the 5bfa/introduce-newdatanamespace branch April 30, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants