-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fix: Ensure GIF and TIFF are treated as images #12159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Ensure GIF and TIFF are treated as images #12159
Conversation
…b.com/f-pereira/Files into fix/add_giff_tiff_extensions_as_image
There's a bug when rotating GIFs, but I think it's a different issue |
Oh I see, It seems that only the first frame is rotated |
Thank you for your PR! This page will help you to rotate all frames.
|
@hishitetsu Thank you for the documentation! I tried to use it and I found a problem that I am Looking for solution: the first frame rotates well, but if the next frame have a different width/height, it rotates well but It is misplaced (e.g It is placed on top right corner instead of center) |
If no to the former and yes to the latter, I think that is still fine. |
@hishitetsu Done! |
I'm getting a frame wrong (but if I rotate the gif 4 times everything works). I used this to test |
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
I noticed that File Explorer does not have the feature to rotate GIFs maybe because the problem above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works for me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Resolved / Related Issues
Closes Bug: GIF and TIFF aren't treated as images #12133
Validation
How did you test these changes?
Screenshots (optional)
