Skip to content

Code Quality: Introduce Implicit Usings #12121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Apr 19, 2023

Description

Added GlobalUsings.cs so that we reduce lines of using directives.

Detials

  • Add GlobalUsings.cs
  • Fix IDE0005 with VS2022 IntelliSence (automation)
  • Fix ambiguous references

PR Check-list

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots

No Responce

@hecksmosis
Copy link
Contributor

I think we should add CommunityToolkit.Mvvm.DependencyInjection, it's used in a lot of the actions and other files

@0x5bfa 0x5bfa changed the title Code Quality: Introduce implicit usings Code Quality: Introduce Implicit Usings Apr 20, 2023
@0x5bfa 0x5bfa marked this pull request as ready for review April 20, 2023 14:23
@0x5bfa
Copy link
Member Author

0x5bfa commented Apr 20, 2023

There're about 500 files in Files.App

So I changed partly; following files:

  • Converters/**
  • DataModels/**
  • EventArguemnts/**
  • Shell/**
  • ValueConverters/**
  • ViewModels/**
  • Views/**
  • **

@yaira2 yaira2 requested a review from QuaintMako April 20, 2023 14:44
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 21, 2023
@yaira2 yaira2 merged commit 06da418 into files-community:main Apr 21, 2023
@0x5bfa 0x5bfa deleted the 5bfa/introduce-implicitusings branch April 21, 2023 13:38
ferrariofilippo pushed a commit to ferrariofilippo/Files that referenced this pull request Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Quality: Global usings, single line namespaces
4 participants