Skip to content

Feature: Settings dialog update #12112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Feature: Settings dialog update #12112

merged 3 commits into from
Apr 18, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Apr 18, 2023

Changes

  • Custom themes now apply to the settings dialog
  • Removed the background from the content area
  • Added headers to the setting pages
  • Added more spacing between sections

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. Click settings button
    3. Tested that custom themes apply to the settings dialog
    4. Tested in light and dark mode
    5. Tested that each settings page has the correct header and spacing

Screenshots (optional)
image

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 18, 2023
@yaira2 yaira2 merged commit cc243ef into main Apr 18, 2023
@yaira2 yaira2 deleted the ya/SettingsPane branch April 19, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant