Skip to content

Fix: Fixed issue where "Send To" submenu was sometimes not displayed on widgets #12093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Apr 17, 2023

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots
image

@yaira2
Copy link
Member

yaira2 commented Apr 17, 2023

@hishitetsu is there a specific scenario that I should test to verify this fix?

@hishitetsu
Copy link
Member Author

@hishitetsu is there a specific scenario that I should test to verify this fix?

Right-click a file that has no extension.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 17, 2023
@yaira2 yaira2 merged commit b88cd4d into files-community:main Apr 17, 2023
@hishitetsu hishitetsu deleted the FixContextMenuOnWidgets branch April 17, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: "Send to" submenu is not displayed when "Open with" has no submenu on widgets
2 participants