RichCommands: SearchUnindexedItems

[ferrariofilippo]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Related Generalizing Rich Command Usage #11481

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Open app
  2. Search something that is not indexed
  3. Click on Search unindexed items

[ferrariofilippo]

@yaira2 I saw you told me to split this PR, but now I no longer see the comment (did you delete it?), should I still open a separate PR for PermanentDeletion?

[yaira2]

It's preferred but I don't want to be too picky.

[ferrariofilippo]

It's preferred but I don't want to be too picky.

I'll do that, don't worry, in the end it's a free contribution 😄

[yaira2]

I'm not convinced this should have an action, it's likely to be confused between the setting and the button on the search page.

[ferrariofilippo]

I'm not convinced this should have an action, it's likely to be confused between the setting and the button on the search page.

I think we could rename it, but we definitely need to add this action. Otherwise we would need to keep IBaseLayoutCommandImplementation just for this action.

[0x5bfa]

First introduction of rich commands in layout modes!

[yaira2]

LGTM

[yaira2]

LGTM

[yaira2]

LGTM