Skip to content

Feature: Translucent hidden or cut item name #12070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 16, 2023

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Apr 15, 2023

This is necessary to identify hidden or cut items when checkboxes are displayed instead of icons.

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Screenshots
image

@hishitetsu hishitetsu marked this pull request as draft April 15, 2023 05:53
@hishitetsu hishitetsu marked this pull request as ready for review April 15, 2023 07:50
@ferrariofilippo
Copy link
Contributor

What about applying Opacity to the whole line in DetailsLayout?

@hishitetsu
Copy link
Member Author

What about applying Opacity to the whole line in DetailsLayout?

I think it's redundant. The items other than the file name are a bit dark, so making them translucent would make the text hard to see.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 16, 2023
@yaira2 yaira2 merged commit c10d6a5 into files-community:main Apr 16, 2023
@hishitetsu hishitetsu deleted the ItemNameOpacity branch April 16, 2023 15:27
@richardhttps
Copy link

Relevant issue
#12249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants