Fix: Fixed Ctrl+A in the rename textbox

[hishitetsu]

Targeted to the servicing branch

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Closes Bug: Ctrl + A shortcut isn't selecting text when renaming files #12040

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?

[ferrariofilippo]

I'm wondering if we should disable all the shortcuts when renaming items...

[hishitetsu]

I'm wondering if we should disable all the shortcuts when renaming items...

Certainly. However, this fix is necessary anyway, since the problem here is not that Select All Items is invoked, but that Select All Text is not invoked. The code is intended to disable the ListView native shortcut and redirect to RichCommand.

[QuaintMako]

LGTM, it solves the issue.

[QuaintMako]

Regarding the disabling of all shortcuts when renaming, that is possibly a good idea.
I'd suggest opening an feature request for it to open discussions around it.

[ferrariofilippo]

Certainly. However, this fix is necessary anyway, since the problem here is not that Select All Items is invoked, but that Select All Text is not invoked. The code is intended to disable the ListView native shortcut and redirect to RichCommand.

I'm sorry probably I was not very clear. That comment meant that we could move if (IsRenamingItem) return; to the top of the method

[ferrariofilippo]

Regarding the disabling of all shortcuts when renaming, that is possibly a good idea. I'd suggest opening an feature request for it to open discussions around it.

Just opened #12053

[hishitetsu]

I'm sorry probably I was not very clear. That comment meant that we could move if (IsRenamingItem) return; to the top of the method

I see. I will address it that way later.

[hishitetsu]

I'm sorry probably I was not very clear. That comment meant that we could move if (IsRenamingItem) return; to the top of the method

I addressed it.