Codebase: Add AppEnvironment enum

[hecksmosis]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Closes Code Quality: Add Environment Enum AppModel #11959
• (probably) needs more usages

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Open app ...
  2. Click settings button ...

Screenshots (optional)
Add screenshots here.

[lukeblevins]

We should be using the IHostEnvironment.EnvironmentName property to set the environment like this:

Host.CreateDefaultBuilder(args)
#if SIDELOAD
    .UseEnvironment("Sideload")
#else
    .UseEnvironment("Store")
#endif
    // ...

[yaira2]

We should be using the IHostEnvironment.EnvironmentName property to set the environment like this:

We'll need to add some more configurations, right now sideload and sideload preview use the same configuration but they have different environments.

[hecksmosis]

We should be using the IHostEnvironment.EnvironmentName property to set the environment like this:

Host.CreateDefaultBuilder(args)
#if SIDELOAD
    .UseEnvironment("Sideload")
#else
    .UseEnvironment("Store")
#endif
    // ...

How would this be done with the enum?

[yaira2]

@hecksmosis we might have to rework this, Luke's suggestion would be instead of an enum but it won't work unless we add additional configurations to the project. I think it's best to use an enum for now and hold off on implementing IHostEnvironment.EnvironmentName.

[hecksmosis]

@hecksmosis we might have to rework this, Luke's suggestion would be instead of an enum but it won't work unless we add additional configurations to the project. I think it's best to use an enum for now and hold off on implementing IHostEnvironment.EnvironmentName.

So should we merge this for the time being or do I modify it?

[yaira2]

@hecksmosis we can merge but I think we should move the code out of app.xaml. The question is to where...

[heftymouse]

Would it be better to set the value using preprocessor directives set by MSBuild instead of reading from the display name?

[yaira2]

@hecksmosis I created the new project configurations so we can switch away from using the display names.

[hecksmosis]

@hecksmosis I created the new project configurations so we can switch away from using the display names.

What are the environment name strings?

[yaira2]

• Store
• Stable
• Preview
• Debug
• Release

[hecksmosis]

Is release the dev version?

[yaira2]

Release and Debug are both dev versions.

[hecksmosis]

Ok

[yaira2]

LGTM