-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Refactor: Continued work on reducing async state machines #12010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Continued work on reducing async state machines #12010
Conversation
36594a2
to
8de8377
Compare
@itsWindows11 can you fix the merge conflicts? |
Will do in a few hours, I'm busy right now. |
@yaira2 Should be done now, feel free to merge. |
There are so many ways these changes could be tested, but I'll try to fill in some now. |
Just finished with filling in the steps (it's not really steps anyway but it involves testing different features). There aren't any breaking changes introduced so it wouldn't require specifying, for example how to extract an archive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Resolved / Related Issues
Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
Continues work on Avoid unnecessary async state machine generation #9871.
Validation
How did you test these changes?
Screenshots (optional)
Add screenshots here.