Skip to content

Refactor: Continued work on reducing async state machines #12010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 9, 2023

Conversation

itsWindows11
Copy link
Contributor

@itsWindows11 itsWindows11 commented Apr 7, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

  • Continues work on Avoid unnecessary async state machine generation #9871.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    • Try doing any operation with archives, bundles and file operations. This includes extracting archives, adding/renaming bundles, or creating a shortcut.

Screenshots (optional)
Add screenshots here.

@itsWindows11 itsWindows11 changed the title Continued work on reducing async state machines Refactor: Continued work on reducing async state machines Apr 7, 2023
@itsWindows11 itsWindows11 force-pushed the imp/less-async-await branch from 36594a2 to 8de8377 Compare April 7, 2023 15:44
@itsWindows11 itsWindows11 marked this pull request as ready for review April 7, 2023 15:45
@yaira2
Copy link
Member

yaira2 commented Apr 20, 2023

@itsWindows11 can you fix the merge conflicts?

@itsWindows11
Copy link
Contributor Author

Will do in a few hours, I'm busy right now.

@itsWindows11
Copy link
Contributor Author

@yaira2 Should be done now, feel free to merge.

@itsWindows11 itsWindows11 requested review from hez2010 and yaira2 April 20, 2023 20:56
@yaira2 yaira2 requested a review from 0x5bfa April 20, 2023 21:28
@itsWindows11
Copy link
Contributor Author

There are so many ways these changes could be tested, but I'll try to fill in some now.

@itsWindows11
Copy link
Contributor Author

itsWindows11 commented Apr 20, 2023

Just finished with filling in the steps (it's not really steps anyway but it involves testing different features). There aren't any breaking changes introduced so it wouldn't require specifying, for example how to extract an archive.

Copy link
Member

@hez2010 hez2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@itsWindows11 itsWindows11 requested a review from hez2010 May 7, 2023 18:14
hez2010
hez2010 previously approved these changes May 8, 2023
Copy link
Member

@hez2010 hez2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 9, 2023
@yaira2 yaira2 merged commit 903aec2 into files-community:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants