Skip to content

Feature: Improved checkbox behavior #11993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Apr 6, 2023

This is slightly different from what we discussed in #11975, but I believe this is the best solution.

  • In details view, unchecked checkboxes now appear only when the icon is hovered.
  • In grid view, checkboxes appear when the item is hovered even if no item is selected (same as 2.4.60).

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Multiselect cannot be used with single click to open enabled #11975

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Movie

Clipchamp.mp4

Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's some code that is not needed

Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hecksmosis hecksmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me

@yaira2
Copy link
Member

yaira2 commented Apr 14, 2023

In details view, unchecked checkboxes now appear only when the icon is hovered.

Are there any concerns that this can make it harder to discover the feature?

@hishitetsu
Copy link
Member Author

hishitetsu commented Apr 14, 2023

Are there any concerns that this can make it harder to discover the feature?

Ticked checkboxes are always displayed, so I think users will notice the feature.
Rather, I think it is more off-putting for users to have icons appear and disappear frequently.

@yaira2 yaira2 merged commit 40c7285 into files-community:main Apr 14, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 14, 2023
@hishitetsu hishitetsu deleted the ImproveCheckbox branch April 14, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Multiselect cannot be used with single click to open enabled
5 participants