-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Feature: Improved checkbox behavior #11993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's some code that is not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works for me
Are there any concerns that this can make it harder to discover the feature? |
Ticked checkboxes are always displayed, so I think users will notice the feature. |
This is slightly different from what we discussed in #11975, but I believe this is the best solution.
Resolved / Related Issues
Closes Bug: Multiselect cannot be used with single click to open enabled #11975
Validation
How did you test these changes?
Movie
Clipchamp.mp4