Skip to content

Fix: Fixed issue where folders with dots in their name couldn't be opened if compressed #11990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open a zip folder containing a folder
    2. Try to open the folder (Important: Layout must be set to Details, since with others it was already working)

@yaira2 yaira2 changed the title Fixed: Folders with dots in their name cannot be opened if compressed Fix: Fixed issue where folders with dots in their name cannot be opened if compressed Apr 5, 2023
@yaira2 yaira2 changed the title Fix: Fixed issue where folders with dots in their name cannot be opened if compressed Fix: Fixed issue where folders with dots in their name couldn't be opened if compressed Apr 5, 2023
@hishitetsu
Copy link
Member

I believe this should be merged into the servicing branch.

@yaira2
Copy link
Member

yaira2 commented Apr 16, 2023

@hishitetsu I want to do a feature release soon so it's okay to target this one to main.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 16, 2023
@yaira2 yaira2 merged commit 025692a into files-community:main Apr 16, 2023
@ferrariofilippo ferrariofilippo deleted the Fixed_Folders_With_Dots branch April 16, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Folders with dots in their name cannot be opened if compressed
3 participants