Skip to content

Code Quality: RemovableDrivesService, IStorageDeviceWatcher #11969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 16, 2023
Merged

Code Quality: RemovableDrivesService, IStorageDeviceWatcher #11969

merged 11 commits into from
Apr 16, 2023

Conversation

lukeblevins
Copy link
Contributor

Please try to break this.

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
N/A

@yaira2 yaira2 changed the title Feature: RemovableDrivesService, IStorageDeviceWatcher Code Quality: RemovableDrivesService, IStorageDeviceWatcher Apr 4, 2023
@lukeblevins
Copy link
Contributor Author

@d2dyno1 Can you do a quick pass-through of the first commit?

@lukeblevins lukeblevins requested a review from d2dyno1 April 6, 2023 14:42
d2dyno1
d2dyno1 previously approved these changes Apr 6, 2023
d2dyno1
d2dyno1 previously approved these changes Apr 15, 2023
Copy link
Member

@d2dyno1 d2dyno1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@yaira2
Copy link
Member

yaira2 commented Apr 16, 2023

@lukeblevins I want to do some additional testing, do you have any ideas I can use to stress test the functionality?

@lukeblevins
Copy link
Contributor Author

@yaira2 I'm pretty satisfied with the reliability of this PR. Let's merge it before the changes get stale again.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Apr 16, 2023
@yaira2
Copy link
Member

yaira2 commented Apr 16, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaira2 yaira2 merged commit 204b7f3 into files-community:main Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants