Skip to content

Fix: Fixed issue with pinning and unpinning shell items in Favorites #11967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 14, 2023
Merged

Fix: Fixed issue with pinning and unpinning shell items in Favorites #11967

merged 17 commits into from
Apr 14, 2023

Conversation

hecksmosis
Copy link
Contributor

@hecksmosis hecksmosis commented Apr 4, 2023 •
edited
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Cannot unpin shell folders #11897

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. Pin a shell folder e.g Libraries
    3. Unpin it
    4. See it doesn't crash the app and it unpins the item correctly

Screenshots (optional)
Add screenshots here.

@hecksmosis hecksmosis changed the title Fix pinning shell items to start Fix: Fix issue with pinning and unpinning shell items in Favorites Apr 4, 2023
@yaira2
Copy link
Member

yaira2 commented Apr 4, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

QuaintMako
QuaintMako reviewed Apr 4, 2023
View reviewed changes
@yaira2 yaira2 changed the title Fix: Fix issue with pinning and unpinning shell items in Favorites Fix: Fixed issue with pinning and unpinning shell items in Favorites Apr 4, 2023
ferrariofilippo
ferrariofilippo suggested changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments on code style and on how to fix build errors.
BTW I can't unpin This PC

hecksmosis and others added 12 commits April 6, 2023 13:54
@hecksmosis @ferrariofilippo
Update src/Files.App/ServicesImplementation/JumpListService.cs
4ebe9ef 
Co-authored-by: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
@hecksmosis @ferrariofilippo
Update src/Files.App/ServicesImplementation/QuickAccessService.cs
ecadb23 
Co-authored-by: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
@hecksmosis @ferrariofilippo
Update src/Files.App/UserControls/Widgets/QuickAccessWidget.xaml.cs
8ba2762 
Co-authored-by: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
@hecksmosis @ferrariofilippo
Update src/Files.App/UserControls/SidebarControl.xaml.cs
db862f4 
Co-authored-by: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
@hecksmosis @ferrariofilippo
Update src/Files.App/ServicesImplementation/JumpListService.cs
0bb4ffd 
Co-authored-by: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
@hecksmosis @ferrariofilippo
Update src/Files.App/ServicesImplementation/JumpListService.cs
a7e3b92 
Co-authored-by: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
@hecksmosis @ferrariofilippo
Update src/Files.App/UserControls/Widgets/QuickAccessWidget.xaml.cs
45e7da4 
Co-authored-by: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
@hecksmosis
Fix bugs
2ea2461
@hecksmosis
Remove duplicate string
ad92d3e
@hecksmosis
Remove isShellFolder
f044ff7
@hecksmosis
Merge branch 'main' into fix_pin_shell_items
4d29b65
@hecksmosis
Merge branch 'main' into fix_pin_shell_items
8b13853
QuaintMako
QuaintMako approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected on my machine. I can pin and unpin shell items.

ferrariofilippo
ferrariofilippo approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works now

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 14, 2023
@yaira2 yaira2 merged commit 73700e2 into files-community:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrariofilippo ferrariofilippo ferrariofilippo approved these changes

@QuaintMako QuaintMako QuaintMako approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Cannot unpin shell folders
4 participants
@hecksmosis @yaira2 @ferrariofilippo @QuaintMako