Skip to content

Fix: Fixed group by date #11845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 26, 2023
Merged

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Mar 26, 2023

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Details

  • This week and last week are now determined based on the current locale settings
  • Added "Future" category for future timestamps
  • Split "Older" category by year

@hishitetsu hishitetsu marked this pull request as draft March 26, 2023 04:26
@hishitetsu hishitetsu marked this pull request as ready for review March 26, 2023 06:31
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resources aside, LGTM

@hishitetsu hishitetsu marked this pull request as draft March 26, 2023 10:16
@hishitetsu hishitetsu marked this pull request as ready for review March 26, 2023 10:33
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 1e7d51c into files-community:main Mar 26, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 26, 2023
@hishitetsu hishitetsu deleted the FixGroupByDate branch March 26, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Formula of Earlier This Week & Last Week Groups in the Downloads folder are not being sorted
3 participants