Skip to content

Codebase: Cleanup unneccessary usings #11832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

hecksmosis
Copy link
Contributor

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Removes unnecessary using directives

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app
    2. See nothing crashes

Screenshots (optional)
Add screenshots here.

@0x5bfa
Copy link
Member

0x5bfa commented Mar 25, 2023

@yaira2 How about introducing Global Usings?

@lukeblevins
Copy link
Contributor

I think we should start the conversation about global usings and single line namespace declarations.

@yaira2
Copy link
Member

yaira2 commented Mar 26, 2023

How about introducing Global Usings?

It's certainly not a priority but it'll be good to see how the other contributors feel about this.

@yaira2 yaira2 merged commit ad193fe into files-community:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants