-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Feature: Added a description to each IAction
#11828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Once this is finished, we can port it over the to the website repo. |
I filled in all the descriptions. |
@hishitetsu I've added a few commands I forgot in #11481. |
Thank you! But for now, this list only covers those merged into main. Once this has been merged, it is ideal to update this document along with the code when submitting a PR. |
We will need to open our eyes for PRs then and make sure we do! |
Don't worry! If the list is missing an update, I will maintain it. |
Should we leave this open until we finish with the rich command work? |
That's also possible. I hope to merge this by the time we start implementing the command palette or shortcut customization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add spaces in table.
You mean |
Yes. and separator should be |
At first I did so, but @yaira2 put in the space. I think it is easier to see it as it is now, but why shouldn't it include spaces? |
@yaira2 This kind indentation will be meaningless even if it is readability by following two major problems.
I also thought this is nice idea before, but it's tiresome, annoying. |
I used a tool to format the table, spaces or dashes are fine, but it doesn't really matter since there are many tools that can format it for you. |
@hishitetsu do you want to add the descriptions to the resource file? I think we have enough to move forward with this. |
Ok, I will do it within a few days. |
IAction
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
Closes Feature: Add a description to each
IAction
#11786Validation
How did you test these changes?