Skip to content

RichCommand: Refresh items #11807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 26, 2023
Merged

RichCommand: Refresh items #11807

merged 14 commits into from
Mar 26, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Mar 22, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • Implements rich command for refresh

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open a folder and click the refresh button in the address bar
    2. Use the ctrl + r keyboard shortcut
    3. Right click in a blank space and verify the refresh option works

Screenshots (optional)
Add screenshots here.

Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but there are other occurences that should be replaced/removed:

  • Remove RefreshItems() from IBaseLayoutCommandImplementationModel.cs
  • Remove RefreshItems() from BaseLayoutCommandImplementationModel.cs
  • Remove RefreshCommand from BaseLayoutCommandViewModel.cs
  • Use RichCommand at lines 197 -> 212 of ContextFlyoutHelper.cs

yaira2 and others added 4 commits March 22, 2023 17:27
Co-authored-by: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
Co-authored-by: Filippo Ferrario <102259289+ferrariofilippo@users.noreply.github.com>
@ferrariofilippo
Copy link
Contributor

Yair in ContextFlyoutItemHelper.cs you can use ContextMenuFlyoutItemViewModelBuilder() as following:

4

@yaira2 yaira2 requested review from marcofranzen99 and ferrariofilippo and removed request for marcofranzen99 March 26, 2023 15:28
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 26, 2023
@yaira2 yaira2 mentioned this pull request Mar 26, 2023
78 tasks
@yaira2 yaira2 merged commit ef0b77e into main Mar 26, 2023
@yaira2 yaira2 deleted the ya/RefreshRichCommand branch March 26, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants