Skip to content

Fix: Fixed file properties when multiple files are selected #11559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2023
Merged

Fix: Fixed file properties when multiple files are selected #11559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ec454c
Fix properties hanging for multiple files
hecksmosis Mar 5, 2023
3617f2f
More fixes
hecksmosis Mar 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/Files.App/Views/Properties/MainPropertiesPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
using Microsoft.UI.Xaml.Input;
using Microsoft.UI.Xaml.Navigation;
using System;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using Windows.Foundation.Metadata;
Expand Down Expand Up @@ -231,8 +233,21 @@ private void AddNavigationViewItemsToControl(object item)

MainPropertiesWindowNavigationView.SelectedItem = generalItem;

// Unable unavailable property tabs
if (item is ListedItem listedItem)
if (item is List<ListedItem> listedItems)
{
var commonFileExt = listedItems.Select(x => x.FileExtension).Distinct().Count() == 1 ? listedItems.First().FileExtension : null;
var compatibilityItemEnabled = listedItems.All(listedItem => FileExtensionHelpers.IsExecutableFile(listedItem is ShortcutItem sht ? sht.TargetPath : commonFileExt, true));

if (!compatibilityItemEnabled)
NavViewItems.Remove(compatibilityItem);

NavViewItems.Remove(libraryItem);
NavViewItems.Remove(shortcutItem);
NavViewItems.Remove(detailsItem);
NavViewItems.Remove(securityItem);
NavViewItems.Remove(customizationItem);
}
else if (item is ListedItem listedItem)
{
var isShortcut = listedItem.IsShortcut;
var isLibrary = listedItem.IsLibrary;
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Views/Properties/SecurityPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ public SecurityPage()
{
InitializeComponent();

OpenAdvancedPropertiesCommand = new RelayCommand(() => OpenAdvancedProperties());
OpenAdvancedPropertiesCommand = new RelayCommand(OpenAdvancedProperties);
}

protected override void OnNavigatedTo(NavigationEventArgs e)
{
var np = e.Parameter as Properties.MainPropertiesPage.PropertyNavParam;
var np = e.Parameter as MainPropertiesPage.PropertyNavParam;

if (np.navParameter is ListedItem listedItem)
{
Expand Down