Skip to content

Fix: Use x:Load in conflicts dialog again #11557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues
Items resolved / related issues by this PR.

Details
In #11399, I used Visibility instead of x:Load because the initial value of the combo box could not be set correctly.
But I found a way to set the initial value correctly for x:Load, so I changed Visibility back to x:Load.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 5, 2023
@yaira2 yaira2 merged commit 9d17822 into files-community:main Mar 5, 2023
@hishitetsu hishitetsu deleted the UsexLoadAgain branch March 5, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants