Skip to content

Feature: Update checkbox behavior in details layout to replace icon #11546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Mar 12, 2023

Conversation

marcelwgn
Copy link
Contributor

This PR updates the behavior of the selection checkboxes in Details layout. Insteaed of listening to the app settings, now the "select all checkbox" will always be visible and the rows checkboxes will replace the icon if the user is hovering over the row or any row is selected.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Update checkbox behavior in details layout to replace icon FeatureUpdate checkbox behavior in details layout to replace icon Mar 5, 2023
@yaira2 yaira2 changed the title FeatureUpdate checkbox behavior in details layout to replace icon Feature: Update checkbox behavior in details layout to replace icon Mar 5, 2023
@yaira2
Copy link
Member

yaira2 commented Mar 9, 2023

@chingucoding can you fix the merge conflicts and update from main?

@yaira2
Copy link
Member

yaira2 commented Mar 10, 2023

@chingucoding it looks like the xaml got messed up in the merge, can you take a look?

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 12, 2023
@yaira2 yaira2 merged commit dae49d6 into files-community:main Mar 12, 2023
@marcelwgn marcelwgn deleted the dev/update-multi-select branch March 12, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants