-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Feature: Update checkbox behavior in details layout to replace icon #11546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yaira2
merged 26 commits into
files-community:main
from
marcelwgn:dev/update-multi-select
Mar 12, 2023
Merged
Feature: Update checkbox behavior in details layout to replace icon #11546
yaira2
merged 26 commits into
files-community:main
from
marcelwgn:dev/update-multi-select
Mar 12, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding/Files into dev/update-multi-select
@chingucoding can you fix the merge conflicts and update from |
@chingucoding it looks like the xaml got messed up in the merge, can you take a look? |
…ding/Files into dev/update-multi-select
yaira2
reviewed
Mar 12, 2023
yaira2
reviewed
Mar 12, 2023
yaira2
reviewed
Mar 12, 2023
…ding/Files into dev/update-multi-select
yaira2
approved these changes
Mar 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the behavior of the selection checkboxes in Details layout. Insteaed of listening to the app settings, now the "select all checkbox" will always be visible and the rows checkboxes will replace the icon if the user is hovering over the row or any row is selected.
Validation
How did you test these changes?
Screenshots (optional)
Add screenshots here.