Skip to content

Feature: Display NOTICE.md in the About page #11531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 7, 2023

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Mar 2, 2023

Resolved / Related Issues
Items resolved / related issues by this PR.

Details
This may not be necessary since @d2dyno1 is working on the license page, but I submit it for reference.
NOTICE.md is included in the application package instead of referencing the online one since the third-party libraries used may change from version to version.
I also removed the link to the license of QuickLook since it is not included in Files and merely has the feature to call it.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots
image

@0x5bfa
Copy link
Member

0x5bfa commented Mar 2, 2023

FIiles don’t have display full license term. So if you’d like to add 3rd party notice in Files, display only package name by using Hyperlink Button as I told you what WinUI3-Gallery like. That’s sth kinda redundant.

@hishitetsu
Copy link
Member Author

Displaying third party licenses is to comply with their licenses, so it is different from whether or not Files itself has the feature to display its own license.
For example, Windows Terminal does not have the feature to display its own license, but it does have third party notices.
image
(Sorry for Japanese)

@0x5bfa
Copy link
Member

0x5bfa commented Mar 2, 2023

Me too Japanese, in fact. this PR's problem is redundancy.

@hishitetsu
Copy link
Member Author

Me too Japanese, in fact.

I knew it! So I uploaded the screenshot in Japanese 😃

this PR's problem is redundancy.

That is a point to be discussed.
In Windows Terminal, the browser is opened to show the HTML file converted from NOTICE.md as third-party notices. I don't think this is a good idea, so I have embedded NOTICE.md in the About page.
In any case, users will not care much about third-party licenses, so I think it would be sufficient to display NOTICE.md as it is.

@yaira2
Copy link
Member

yaira2 commented Mar 7, 2023

@hishitetsu can you fix the merge conflicts?

@hishitetsu
Copy link
Member Author

@hishitetsu can you fix the merge conflicts?

Successfully merged the upstream main.

@hishitetsu hishitetsu marked this pull request as draft March 7, 2023 08:31
@hishitetsu hishitetsu marked this pull request as ready for review March 7, 2023 13:31
yaira2
yaira2 previously approved these changes Mar 7, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 7, 2023
@yaira2
Copy link
Member

yaira2 commented Mar 7, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaira2 yaira2 merged commit f0a693d into files-community:main Mar 7, 2023
@hishitetsu hishitetsu deleted the ThirdPartyLicense branch March 8, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants