-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Feature: Display NOTICE.md in the About page #11531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FIiles don’t have display full license term. So if you’d like to add 3rd party notice in Files, display only package name by using Hyperlink Button as I told you what WinUI3-Gallery like. That’s sth kinda redundant. |
Me too Japanese, in fact. this PR's problem is redundancy. |
I knew it! So I uploaded the screenshot in Japanese 😃
That is a point to be discussed. |
@hishitetsu can you fix the merge conflicts? |
Successfully merged the upstream main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Resolved / Related Issues
Items resolved / related issues by this PR.
Details
This may not be necessary since @d2dyno1 is working on the license page, but I submit it for reference.
NOTICE.md is included in the application package instead of referencing the online one since the third-party libraries used may change from version to version.
I also removed the link to the license of QuickLook since it is not included in Files and merely has the feature to call it.
Validation
How did you test these changes?
Screenshots
