-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Feature: Added hashes tab to properties window #11521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com>
Clicking the hashes page for large files causes the properties window to freeze. |
…8/Files into 5bfa/introduce-hashprops
Ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little thing, otherwise LGTM and works for me
src/Files.App/ResourceDictionaries/NavigationViewStoreStyle.xaml
Outdated
Show resolved
Hide resolved
I cannot fix an issue where Files will freeze as loading a large file(1 GiB or more).
await is bad? maybe Task.Run()? |
How about using |
Have you included a progress ring or progress bar as the hashes are being calculated? |
@yaira2 Tried new one. Can you check also? Works fine for me. |
@mdtauk there is a progress ring 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
I'm adding hash page to storage object's properties window.
Motivation and Context
Validation
Screenshots
Loading

Left: Managed to load, Right: Failed to load
