Skip to content

Fix: Fixed crash on the tags settings page #11447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 16, 2023
Merged

Fix: Fixed crash on the tags settings page #11447

merged 11 commits into from
Mar 16, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Notes

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@ferrariofilippo ferrariofilippo marked this pull request as draft February 24, 2023 09:54
@yaira2 yaira2 changed the title Tags crash Fix: Fixed crash on the tags settings page Feb 26, 2023
@ferrariofilippo ferrariofilippo marked this pull request as ready for review March 4, 2023 21:19
@ferrariofilippo
Copy link
Contributor Author

I marked this as Ready for review since there has been no update to #11400

yaira2
yaira2 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit c466080 into files-community:main Mar 16, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Mar 16, 2023
@ferrariofilippo ferrariofilippo deleted the Tags_Crash branch March 16, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Settings tags page crashes Files if Colour code is invalid or null
2 participants
@ferrariofilippo @yaira2