Skip to content

Fix: Fixed issue where right clicking an item wouldn't show the context menu #11401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marcofranzen99
Copy link
Contributor

@marcofranzen99 marcofranzen99 commented Feb 21, 2023

Description
Context menu was not shot showing up on main branch because of a NullReferenceException
Only occured when clicking on an item (file or directory). Empty space or sidebar item is working as expected

Caused by #11364

Resolved / Related Issues
Items resolved / related issues by this PR.

  • None

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
The exception
image

@yaira2 yaira2 changed the title Fix: Right clicking any item does not show context menu Fix: Fixed issue where right clicking an item wouldn't show the context menu Feb 21, 2023
@yaira2
Copy link
Member

yaira2 commented Feb 21, 2023

@mafra99 this also breaks #11364

@marcofranzen99
Copy link
Contributor Author

@yaira2 are you sure? i have tested "format drive" both over the sidebar and over an empty space in the details layout and it woked both witout and also with my changes.
or am i missing something?

@yaira2
Copy link
Member

yaira2 commented Feb 22, 2023

It's missing from the sidebar and drives widget, but seems to be an issue in main as well.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 0eaa89f into files-community:main Feb 22, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 22, 2023
@marcofranzen99 marcofranzen99 deleted the rightClickMenuNotWorking branch February 22, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants