Skip to content

Codebase: Join both context menus in BaseLayout #11357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 20, 2023
Merged

Codebase: Join both context menus in BaseLayout #11357

merged 4 commits into from
Feb 20, 2023

Conversation

hecksmosis
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Joins both context menus in BaseLayout (GetBaseItemMenuItems and GetBaseLayoutMenuItems) as requested by @yaira2

Validation
How did you test these changes?

  • Built and ran the app

yaira2
yaira2 approved these changes Feb 19, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 requested a review from QuaintMako February 19, 2023 00:48
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 19, 2023
@yaira2 yaira2 merged commit e1e56ca into files-community:main Feb 20, 2023
@yaira2
Copy link
Member

yaira2 commented Feb 21, 2023

It seems like right clicking an empty space shows an empty menu.

@hecksmosis hecksmosis mentioned this pull request Feb 21, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@QuaintMako QuaintMako Awaiting requested review from QuaintMako

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hecksmosis @yaira2