Skip to content

Feature: Added Tags section in settings #11320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 16, 2023
Merged

Feature: Added Tags section in settings #11320

merged 6 commits into from
Feb 16, 2023

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Feb 16, 2023 •
edited by yaira2
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Closes None

Notes

  • At the moment this section contains only the menu for adding/editing/deleting tags, which other options should I add?

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@ferrariofilippo ferrariofilippo mentioned this pull request Feb 16, 2023
Closed
yaira2
yaira2 reviewed Feb 16, 2023
View reviewed changes
yaira2
yaira2 reviewed Feb 16, 2023
View reviewed changes
@yaira2
Copy link
Member

yaira2 commented Feb 16, 2023 •
edited
Loading

Can you edit the tests project to include this settings page?

@yaira2
Copy link
Member

yaira2 commented Feb 16, 2023 •
edited
Loading

At the moment this section contains only the menu for adding/editing/deleting tags, which other options should I add?

It's a little empty but I think this is all for now.

yaira2
yaira2 approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 0eb8ac0 into files-community:main Feb 16, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 16, 2023
@ferrariofilippo ferrariofilippo deleted the Moved_Tags_To_Own_Page branch March 6, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferrariofilippo @yaira2