Skip to content

Feature: Move open with to main menu when right clicking recent files #11304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 16, 2023
Merged

Feature: Move open with to main menu when right clicking recent files #11304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7a8aca1
Move open with to main menu when right clicking recent files
hecksmosis Feb 14, 2023
cf4c0de
Merge branch 'main' into open_with_in_recent_items
hecksmosis Feb 15, 2023
43d3f27
Merge branch 'main' of https://github.com/files-community/Files into …
hecksmosis Feb 15, 2023
b4ed72c
Merge branch 'main' into open_with_in_recent_items
hecksmosis Feb 15, 2023
0adcd85
Merge branch 'main' into open_with_in_recent_items
hecksmosis Feb 15, 2023
c0513a5
Merge branch 'main' into open_with_in_recent_items
hecksmosis Feb 16, 2023
eb37499
Merge branch 'main' of https://github.com/files-community/Files into …
hecksmosis Feb 16, 2023
c9784d7
Merge branch 'main' into open_with_in_recent_items
yaira2 Feb 16, 2023
409be5a
Merge branch 'main' of https://github.com/files-community/Files into …
hecksmosis Feb 16, 2023
1446bf3
Add icon + color icon and placeholder
hecksmosis Feb 16, 2023
7e96041
Merge branch 'open_with_in_recent_items' of https://github.com/hecksm…
hecksmosis Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Files.App/Helpers/ShellContextMenuHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,15 @@ public static async Task LoadShellMenuItems(string path, CommandBarFlyout itemCo
var openWithItem = shellMenuItems.Where(x => (x.Tag as Win32ContextMenuItem)?.CommandString == "openas").ToList().FirstOrDefault();
if (openWithItem is not null)
{
openWithItem.ColoredIcon = new ColoredIconModel()
{
BaseLayerGlyph = "\uF049",
OverlayLayerGlyph = "\uF04A",
};
var (_, openWithItems) = ItemModelListToContextFlyoutHelper.GetAppBarItemsFromModel(new List<ContextMenuFlyoutItemViewModel>() { openWithItem });
var placeholder = itemContextMenuFlyout.SecondaryCommands.Where(x => Equals((x as AppBarButton)?.Tag, "OpenWithPlaceholder")).FirstOrDefault() as AppBarButton;
if (placeholder is not null)
placeholder.Visibility = Visibility.Collapsed;
itemContextMenuFlyout.SecondaryCommands.Insert(0, openWithItems.FirstOrDefault());
shellMenuItems.Remove(openWithItem);
}
Expand Down
9 changes: 8 additions & 1 deletion src/Files.App/UserControls/Widgets/RecentFilesWidget.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ private void Grid_RightTapped(object sender, RightTappedRoutedEventArgs e)
secondaryElements.ForEach(i => itemContextMenuFlyout.SecondaryCommands.Add(i));
itemContextMenuFlyout.ShowAt(recentItemsGrid, new FlyoutShowOptions { Position = e.GetPosition(recentItemsGrid) });

_ = ShellContextmenuHelper.LoadShellMenuItems(item.Path, itemContextMenuFlyout);
_ = ShellContextmenuHelper.LoadShellMenuItems(item.Path, itemContextMenuFlyout, showOpenWithMenu: true);

e.Handled = true;
}
Expand All @@ -126,6 +126,13 @@ public override List<ContextMenuFlyoutItemViewModel> GetItemMenuItems(WidgetCard
{
return new List<ContextMenuFlyoutItemViewModel>()
{
new ContextMenuFlyoutItemViewModel()
{
Text = "OpenItemsWithCaptionText".GetLocalizedResource(),
Glyph = "\uE17D",
Tag = "OpenWithPlaceholder",
IsEnabled = false
},
new ContextMenuFlyoutItemViewModel()
{
Text = "RecentItemRemove/Text".GetLocalizedResource(),
Expand Down