Skip to content

Feature: Added option to confirm permanent deletion only #11212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 8, 2023
Merged

Feature: Added option to confirm permanent deletion only #11212

merged 5 commits into from
Feb 8, 2023

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Feb 8, 2023 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Details

  • The setting to show a delete confirmation dialog now has three choices: Always, Permanent deletion only, Never.
  • When "Never" is selected, the dialog to confirm emptying the recycle bin will also not appear.
  • To avoid errors when updating, the setting will be "Always" after updating regardless of the previous setting.

Screenshots
image

yaira2
yaira2 previously approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 8, 2023
@yaira2 yaira2 changed the title Feature: Add settings to confirm permanent deletion only Feature: Added option to confirm permanent deletion only Feb 8, 2023
@yaira2 yaira2 merged commit 1280b06 into files-community:main Feb 8, 2023
@hishitetsu hishitetsu deleted the ConfirmPermanentDeletionOnly branch February 8, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show warning for permanent deletion; no warning otherwise
2 participants
@hishitetsu @yaira2