Skip to content

Fix: Refactor smb credentials dialog logic #11193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2023
Merged

Fix: Refactor smb credentials dialog logic #11193

merged 2 commits into from
Feb 17, 2023

Conversation

radu-cernatescu
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Solves the following discussion.
    • Move the call to AuthenticateNetworkShare() to ItemViewModel.cs.
    • Remove logic added to ToolbarViewModel.cs & NavigationHelpers.cs

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@radu-cernatescu radu-cernatescu mentioned this pull request Feb 7, 2023
Merged
2 tasks
@yaira2 yaira2 requested a review from gave92 February 7, 2023 01:57
yaira2
yaira2 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 607eb50 into files-community:main Feb 17, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 17, 2023
@radu-cernatescu radu-cernatescu deleted the smb-dialog-refactor branch February 17, 2023 17:41
@ferrariofilippo ferrariofilippo mentioned this pull request Feb 22, 2023
Merged
2 tasks
@marcofranzen99 marcofranzen99 mentioned this pull request Mar 21, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@gave92 gave92 Awaiting requested review from gave92

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radu-cernatescu @yaira2