Skip to content

Fix: Fixed icon not showing in stable and preview builds #11188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

hecksmosis
Copy link
Contributor

@hecksmosis hecksmosis commented Feb 6, 2023

Resolved / Related Issues
Items resolved / related issues by this PR.

  • Fixes logo not showing in preview and stable builds

Validation
How did you test these changes?

  • Built and ran the app

@hecksmosis hecksmosis changed the title Fix: Fix logo not showing in stable and preview builds Fix: Fix icon not showing in stable and preview builds Feb 6, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix: Fix icon not showing in stable and preview builds Fix: Fixed icon not showing in stable and preview builds Feb 6, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 6, 2023
@yaira2 yaira2 merged commit 98cd803 into files-community:main Feb 6, 2023
@@ -93,6 +94,8 @@ public App()
InitializeComponent();
Services = ConfigureServices();
Ioc.Default.ConfigureServices(Services);
LogoPath = Package.Current.DisplayName == "Files - Dev" ? Constants.AssetPaths.DevLogo
: (Package.Current.DisplayName == "Files - Preview" ? Constants.AssetPaths.PreviewLogo : Constants.AssetPaths.StableLogo);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The display name for preview is Files (Preview)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants